So, let's look at potential solutions:
Raise pay, working conditions and benefits for soldiers until the job starts to appeal again.
Disadvantages:
American Foreign League. Service guarantees citizenship.
- Expensive, I can just hear the bureaucrats squealing now at the very thought.
- After decades of constant lying, who'd trust the recruiter propagandists that this time they weren't gonna screw you over?
- Could allow soldiers to build up wealth, contrary to the long-term goal of reducing everyone but the plutocrats to bankrupt rent-slaves.
Disadvantages:
Fuck up the economy so badly that hiring yourselves out as glorified mercenaries is the only available career.
- You know all those statistics about how many American soldiers would refuse to fire upon American citizens or otherwise refuse totalitarian orders against their own people? Not an issue with a foreign varangian guard.
- An Arminius or even an Odoacer scenario. Traditionally, replacing untrustworthy native soldiers with barbarian mercenaries keeps backfiring spectacularly.
Disadvantages:
Robots.
- If you're gonna be at risk of getting shot in the process of fighting a war anyway, why join the army of the people who put you in that situation instead of one of the civilian militias forming to take revenge on them? It'd be the fall of the Weimar Republic all over again, only this time the scapegoats genuinely would be guilty.
Disadvantages:
- Technology isn't quite there yet, ask again in another decade or two. Yeah, I've heard all the conspiracy theories about the military-industry complex black budget, keeping gadgetry ahead of the civilian market to themselves and the supposed real reason for the global microchip shortage, but I don't believe them, much more likely that the money got embezzled on account of the lack of oversight than used to build an army of terminators.
- Same loyalty-to-the-politicians-not-the-people varangian guard issue as an American Foreign League.
- If their loyalty can be challenged, there's always the risk that suddenly the entire leadership of the status quo will be massacred by their own bodyguards and the Boston Dynamics CEO, some peon coder who put a backdoor in their software, the hacker known as 4chan, an unexpectedly intelligent artificially intelligent operating system, etc, proclaims themselves the first American Emperor.
another option is to just bring back the draft or conscription.